Skip to content

feat: Add regex validation #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 28, 2025
+36 −6
Merged

feat: Add regex validation #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8167d6d
feat: Add regex validation
Oct 8, 2025
c75ec25
Merge branch 'main' into en-regex
arya-girish-k Oct 15, 2025
46b84d9
fix: Updated terratest version
Oct 17, 2025
dfc2888
Merge branch 'main' into en-regex
arya-girish-k Oct 17, 2025
840c072
fix(deps): update dependencies (#483)
terraform-ibm-modules-ops Oct 18, 2025
828a9be
fix(deps): update dependencies (#484)
terraform-ibm-modules-ops Oct 18, 2025
dd16f72
fix(deps): update terraform terraform-ibm-modules/kms-all-inclusive/i…
terraform-ibm-modules-ops Oct 18, 2025
2d3c8b3
fix(deps): update terraform terraform-ibm-modules/kms-all-inclusive/i…
terraform-ibm-modules-ops Oct 18, 2025
517d621
fix: resolved conflicts
Oct 21, 2025
e62d14f
Merge branch 'main' into en-regex
arya-girish-k Oct 21, 2025
82a8ff5
Merge branch 'main' into en-regex
Oct 22, 2025
ea153cf
fix: Addressed review comments
Oct 22, 2025
cc2af1d
fix: Addressed review comments
Oct 22, 2025
be8833a
Merge branch 'main' into en-regex
arya-girish-k Oct 27, 2025
77b9be2
Merge branch 'main' into en-regex
ocofaigh Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions ibm_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,14 @@
"hidden": true
},
{
"key": "existing_secrets_manager_instance_crn"
"key": "existing_secrets_manager_instance_crn",
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'existing_secrets_manager_instance_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
},
{
"key": "service_credential_secrets",
Expand Down Expand Up @@ -687,10 +694,24 @@
"key": "ibmcloud_kms_api_key"
},
{
"key": "existing_kms_key_crn"
"key": "existing_kms_key_crn",
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'existing_kms_key_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}(kms|hs-crypto):(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}:key:[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}$"
}
]
},
{
"key": "existing_kms_instance_crn"
"key": "existing_kms_instance_crn",
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'existing_kms_instance_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}(kms|hs-crypto):(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
},
{
"key": "kms_key_name"
Expand Down Expand Up @@ -733,7 +754,14 @@
"hidden": true
},
{
"key": "existing_secrets_manager_instance_crn"
"key": "existing_secrets_manager_instance_crn",
"value_constraints": [
{
"type": "regex",
"description": "The value provided for 'existing_secrets_manager_instance_crn' is not valid.",
"value": "^__NULL__$|^crn:(.*:){3}secrets-manager:(.*:){2}[0-9a-fA-F]{8}(?:-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}::$"
}
]
},
{
"key": "service_credential_secrets",
Expand Down
3 changes: 2 additions & 1 deletion solutions/quickstart/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ variable "region" {

variable "prefix" {
type = string
description = "The prefix to be added to all resources created by this solution. To skip using a prefix, set this value to null or an empty string. The prefix must begin with a lowercase letter and may contain only lowercase letters, digits, and hyphens '-'. It should not exceed 16 characters, must not end with a hyphen('-'), and can not contain consecutive hyphens ('--'). Example: prod-0205-es. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix)."
nullable = true
description = "The prefix to add to all resources that this solution creates (e.g `prod`, `test`, `dev`). To skip using a prefix, set this value to null or an empty string. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)."

validation {
condition = (var.prefix == null || var.prefix == "" ? true :
Expand Down
3 changes: 2 additions & 1 deletion solutions/security-enforced/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ variable "region" {

variable "prefix" {
type = string
description = "The prefix to be added to all resources created by this solution. To skip using a prefix, set this value to null or an empty string. The prefix must begin with a lowercase letter and may contain only lowercase letters, digits, and hyphens '-'. It should not exceed 16 characters, must not end with a hyphen('-'), and can not contain consecutive hyphens ('--'). Example: prod-0205-es. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix)."
nullable = true
description = "The prefix to add to all resources that this solution creates (e.g `prod`, `test`, `dev`). To skip using a prefix, set this value to null or an empty string. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/prefix.md)."

validation {
condition = (var.prefix == null || var.prefix == "" ? true :
Expand Down