Fix draw_key_rect() not using data$fill for glyph fill #6609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #6608:
Created on 2025-09-12 with reprex v2.1.1
As an aside, the pattern of checking if a value is NULL or NA seems to be a common one in defaulting aesthetics that could be wrapped up into a helpful infix function, e.g.
x %NA0% y
to usey
ifx
isNA
or empty. Looking at the code here, it seems that if both fill and colour are NA, then"grey20"
may not be used?