Skip to content

Fix draw_key_rect() not using data$fill for glyph fill #6609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

Fix draw_key_rect() not using data$fill for glyph fill #6609

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc774ad
Fix draw_key_rect() not using data$fill for glyph fill
mitchelloharawild Sep 12, 2025
dd50a54
Accept snapshot and update NEWS
mitchelloharawild Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# ggplot2 (development version)

### Bug fixes

* Fixed regression where `draw_key_rect()` stopped using `fill` colours (#6609).

# ggplot2 4.0.0

## User facing
Expand Down
2 changes: 1 addition & 1 deletion R/legend-draw.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ draw_key_abline <- function(data, params, size) {
#' @export
#' @rdname draw_key
draw_key_rect <- function(data, params, size) {
colour <- if (is.na(data$fill %||% NA)) data$colour
colour <- if (is.na(data$fill %||% NA)) data$colour else data$fill
rectGrob(gp = gg_par(
col = NA,
fill = fill_alpha(colour %||% "grey20", data$alpha),
Expand Down
Loading