Refactor BSP module with dependency inversion and iterators #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement dependency inversion pattern using BspOps trait - Create separate SerialBspOps and ParallelBspOps implementations - Replace manual loops with iterator patterns throughout - Maintain backward compatibility with existing Node API - Add SplittingPlaneStrategy trait for algorithm flexibility - Organize code into clean submodule structure: - traits.rs: Core trait definitions - node.rs: Node data structure only - serial.rs: Serial BSP operations - parallel.rs: Parallel BSP operations (with rayon) - mod.rs: Public API and backward compatibility - Fix doctest import issues and create missing directories - All tests passing (98 lib tests + 28 doc tests) This refactoring separates algorithms from data structures, enables easy testing of different BSP strategies, and follows modern Rust patterns while maintaining full API compatibility.
- Implement dependency inversion pattern using BspOps trait - Create separate SerialBspOps and ParallelBspOps implementations - Replace manual loops with iterator patterns throughout - Maintain backward compatibility with existing Node API - Add SplittingPlaneStrategy trait for algorithm flexibility - Organize code into clean submodule structure: - traits.rs: Core trait definitions - node.rs: Node data structure only - serial.rs: Serial BSP operations - parallel.rs: Parallel BSP operations (with rayon) - mod.rs: Public API and backward compatibility - Fix doctest import issues and create missing directories - All tests passing (98 lib tests + 28 doc tests) This refactoring separates algorithms from data structures, enables easy testing of different BSP strategies, and follows modern Rust patterns while maintaining full API compatibility.
- Implement dependency inversion pattern using BspOps trait - Create separate SerialBspOps and ParallelBspOps implementations - Replace manual loops with iterator patterns throughout - Maintain backward compatibility with existing Node API - Add SplittingPlaneStrategy trait for algorithm flexibility - Organize code into clean submodule structure: - traits.rs: Core trait definitions - node.rs: Node data structure only - serial.rs: Serial BSP operations - parallel.rs: Parallel BSP operations (with rayon) - mod.rs: Public API and backward compatibility - Fix doctest import issues and create missing directories - All tests passing (98 lib tests + 28 doc tests) This refactoring separates algorithms from data structures, enables easy testing of different BSP strategies, and follows modern Rust patterns while maintaining full API compatibility.
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
…m/ryancinsight/csgrs into refactor/bsp-dependency-inversion
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on e3113a7..f6c932f
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (18)
• examples/adjacency_demo.rs
• src/io/stl.rs
• src/lib.rs
• src/main.rs
• src/mesh/bsp.rs
• src/mesh/bsp/mod.rs
• src/mesh/bsp/node.rs
• src/mesh/bsp/parallel.rs
• src/mesh/bsp/serial.rs
• src/mesh/bsp/traits.rs
• src/mesh/bsp_parallel.rs
• src/mesh/metaballs.rs
• src/mesh/mod.rs
• src/nurbs/mod.rs
• src/sketch/extrudes.rs
• src/sketch/hershey.rs
• src/sketch/shapes.rs
• src/tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring separates algorithms from data structures, enables easy testing of different BSP strategies, and follows modern Rust patterns while maintaining full API compatibility.