Skip to content

Conversation

goerz
Copy link

@goerz goerz commented Dec 2, 2024

The makefile refers to grammar.js, but the project actually uses grammar.json. This made make fail.

@Biswa96
Copy link

Biswa96 commented Mar 21, 2025

Would it be possible to merge this pull request please? This fixes a build issue.

@TomJo2000
Copy link

Already fixed it by using cmake.

@jpalus
Copy link
Contributor

jpalus commented Mar 23, 2025

I don't think changing dependency to grammar.json is correct here. Both parser.c and grammar.json are generated at the same time so it's unlikely this rule would be ever triggered.

I believe the proper fix would be to correct path to grammar.js by dropping $(SRC_DIR)/ prefix in:

$(PARSER): $(SRC_DIR)/grammar.js
$(TS) generate $^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants