fix(native): fixed BTC fees rounding, correct decimal pad for custom fee #22411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OriginalEveres
force-pushed
the
fix/native/btc-fees
branch
from
a123fd5 to
f0df400
Compare
OriginalEveres
force-pushed
the
fix/native/btc-fees
branch
from
f0df400 to
596f4fb
Compare
Lemonexe
approved these changes
Oct 13, 2025
| return String(Math.round(Number(feeLevel.fee) / transactionBytes)); | ||
| const feePerVb = Number(feeLevel.fee) / transactionBytes; | ||
|
|
||
| return Number.isInteger(Number(feePerVb)) ? String(feePerVb) : Number(feePerVb).toFixed(2); |
There was a problem hiding this comment.
feePerVb was alredy cast to number
Suggested change
| return Number.isInteger(Number(feePerVb)) ? String(feePerVb) : Number(feePerVb).toFixed(2); | |
| return Number.isInteger(feePerVb) ? String(feePerVb) : feePerVb.toFixed(2); |
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/18479657299 |
trezor-bot
bot
force-pushed
the
fix/native/btc-fees
branch
from
596f4fb to
2d2bbf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Related Issue
Resolve #22400
Screenshots:
BEFORE:
AFTER:
🔍🖥️ Suite native android test results: View in Currents