Skip to content

fix: allow empty PBXProject.TargetAttributes #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2025
Merged

fix: allow empty PBXProject.TargetAttributes #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0140b67
allow empty TargetAttributes
MouadBenjrinija Apr 7, 2025
9e943ca
fix unit tests
MouadBenjrinija Apr 7, 2025
43b7245
fix unit test name
MouadBenjrinija Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions Sources/XcodeProj/Objects/Project/PBXProject.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,9 +572,7 @@ extension PBXProject: PlistSerializable {
plistTargetAttributes[reference.value] = value
}

if !plistTargetAttributes.isEmpty {
plistAttributes[PBXProject.targetAttributesKey] = .attributeDictionary(plistTargetAttributes)
}
plistAttributes[PBXProject.targetAttributesKey] = .attributeDictionary(plistTargetAttributes)

dictionary["attributes"] = plistAttributes.plist()

Expand Down
8 changes: 3 additions & 5 deletions Tests/XcodeProjTests/Objects/Project/PBXProjectTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ final class PBXProjectTests: XCTestCase {
XCTAssertEqual(attributes, expectedAttributes)
}

func test_plistKeyAndValue_doesntReturnTargetAttributes_when_itsEmpty() throws {
func test_plistKeyAndValue_returnsEmptyTargetAttributes_when_itsEmpty() throws {
// Given
let target = PBXTarget(name: "")
target.reference.fix("app")
Expand All @@ -81,14 +81,12 @@ final class PBXProjectTests: XCTestCase {
minimizedProjectReferenceProxies: nil,
mainGroup: PBXGroup())

project.setTargetAttributes(["custom": "abc", "TestTargetID": .targetReference(testTarget)], target: target)

// When
let plist = try project.plistKeyAndValue(proj: PBXProj(), reference: "")

// Then
let attributes: [CommentedString: PlistValue]? = plist.value.dictionary?["TargetAttributes"]?.dictionary
XCTAssertNil(attributes)
let attributes = plist.value.dictionary?["attributes"]?.dictionary?["TargetAttributes"]?.dictionary
XCTAssertEqual(attributes, [:])
}

func test_addLocalSwiftPackage() throws {
Expand Down
Loading