fix: allow empty PBXProject.TargetAttributes
#924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
approved these changes
Apr 7, 2025
fortmarek
changed the title
PBXProject.TargetAttributesPBXProject.TargetAttributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves tuist/tuist#6914
Short description 📝
The change introduced in this PR #865 caused the
Fastlane'sautomatic_code_signingaction to fail, although the original PR author did recommend not merging that PR until Fastlane merges the other -unfortunately forgotten- PR fastlane/fastlane#23872 (which was supposed to fix the issue fromFastlaneaction side). It was recommended by @fortmarek here to revert these changes.Solution 📦
The fix is to revert the other PR's changes, by allowing empty
TargetAttributesentry to be generated again. (at least untilFastlanefixes the issue from their side).Implementation 👩💻👨💻
TargetAttributes.TargetAttributeswas empty, because they used to point to the wrong place in the dictionary - always resulting nil - )