[UPDATE] SMS Forward & SMS Forward Multiple Templates #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content has been moved to forward-message only
anthonyjdella
force-pushed
the
forward-message
branch
from
ce4a869 to
94e7b25
Compare
bnb
reviewed
Sep 25, 2024
| # required: true | ||
| # link: https://www.twilio.com/docs/glossary/what-e164 | ||
| MY_PHONE_NUMBER=+12223334444 | ||
| FORWARDING_NUMBERS=+12223334444,+491761234567 |
There was a problem hiding this comment.
Hey all I'm going to go ahead and accept this one for now so we can get the basic update live with the maestro redeployment that is being scheduled for tonight, and we can fix the forwarding number with the next update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated both the
SMS Forward&SMS Forward Multipletemplates since there was duplication. I combined them into a single template which accounts for single and multiple numbers. In doing so, I added comments, updated and added test cases, and improved misc changes. I also completed deleted the template forSMS Forward Multipleas this is no longer needed.Checklist
npm testlocally and it passed without errors.Related issues