-
Notifications
You must be signed in to change notification settings - Fork 348
[UPDATE] SMS Forward & SMS Forward Multiple Templates #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
forward-message-multiple/functions/forward-message-multiple.protected.js
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
52 changes: 0 additions & 52 deletions
52
forward-message-multiple/tests/forward-message-multiple.test.js
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,36 @@ | ||
/* | ||
* Forward a Message to a Specified Number or List of Numbers | ||
* | ||
* Description: When your Twilio Phone Number associated with this function | ||
* receives an SMS, it will forward the message to the phone number(s) listed | ||
* in FORWARDING_NUMBERS specified in /.env. This will work whether a single | ||
* number or multiple numbers are listed. | ||
* | ||
* Contents: | ||
* 1. Main Handler | ||
*/ | ||
|
||
/* | ||
* 1. Main Handler | ||
* | ||
* This is the entry point to your Twilio Function, | ||
* which will create a new MessagingResponse using TwiML | ||
* and forward the incoming SMS to each number specified in | ||
* the FORWARDING_NUMBERS environment variable. | ||
* | ||
* We then use the callback to return from your function | ||
* with the TwiML MessagingResponse you defined earlier. | ||
* In the callback, in non-error situations, the first | ||
* parameter is null and the second parameter | ||
* is the value you want to return. | ||
*/ | ||
|
||
exports.handler = function (context, event, callback) { | ||
const twiml = new Twilio.twiml.MessagingResponse(); | ||
twiml.message( | ||
{ to: context.MY_PHONE_NUMBER }, | ||
`From: ${event.From}. Body: ${event.Body}` | ||
); | ||
|
||
context.FORWARDING_NUMBERS.split(/,\s?/).forEach((number) => { | ||
twiml.message({ to: number }, `From: ${event.From}. Body: ${event.Body}`); | ||
}); | ||
|
||
callback(null, twiml); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"version": "1.0.0", | ||
"version": "1.0.1", | ||
"private": true, | ||
"dependencies": {} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
German number is still here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey all I'm going to go ahead and accept this one for now so we can get the basic update live with the maestro redeployment that is being scheduled for tonight, and we can fix the forwarding number with the next update.