Skip to content

Conversation

@alnr
Copy link
Contributor

@alnr alnr commented Apr 8, 2025

Change Summary

Adds the ability to inspect the ID returned when importing documents with the return_id=true flag.

https://typesense.org/docs/28.0/api/documents.html#returning-the-id-of-the-imported-documents

PR Checklist

@haydenhoang
Copy link
Contributor

haydenhoang commented Apr 12, 2025

Hi @alnr, the types are generated from this API spec, thus changes must be made there. Running go generate ./... will pull the latest API spec source file and generate the types.

@alnr
Copy link
Contributor Author

alnr commented Apr 14, 2025

Hi @alnr, the types are generated from this API spec, thus changes must be made there. Running go generate ./... will pull the latest API spec source file and generate the types.

Hey @haydenhoang. This is true for types_gen.go and types therein. types.go is hand-written, though. The OpenAPI spec does not define a type for this particular API call.

@haydenhoang
Copy link
Contributor

Oh, you're right! It's a custom type defined to parse the JSONL results into a Go slice. @jasonbosco could you approve the workflows?

@haydenhoang
Copy link
Contributor

This can be merged @jasonbosco

@jasonbosco jasonbosco merged commit ed319f0 into typesense:master Apr 17, 2025
2 checks passed
@alnr alnr deleted the alnr/support-return-id-doc branch April 29, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants