Skip to content

feat(api): expose returned IDs when importing documents with return_id=true #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

feat(api): expose returned IDs when importing documents with return_id=true #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions typesense/api/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ type ImportDocumentResponse struct {
Success bool `json:"success"`
Error string `json:"error"`
Document string `json:"document"`
Id string `json:"id"`
}

type StemmingDictionaryWord struct {
Expand Down
6 changes: 3 additions & 3 deletions typesense/import_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,10 @@ func TestDocumentsImportWithTwoDocuments(t *testing.T) {
}
expectedBody := strings.NewReader(`{"id":"123","companyName":"Stark Industries","numEmployees":5215,"country":"USA"}` +
"\n" + `{"id":"125","companyName":"Stark Industries","numEmployees":5215,"country":"USA"}` + "\n")
expectedResultString := `{"success": true}` + "\n" + `{"success": false, "error": "Bad JSON.", "document": "[bad doc"}`
expectedResultString := `{"success": true, "id":"123"}` + "\n" + `{"success": false, "id":"125", "error": "Bad JSON.", "document": "[bad doc"}`
expectedResult := []*api.ImportDocumentResponse{
{Success: true},
{Success: false, Error: "Bad JSON.", Document: "[bad doc"},
{Success: true, Id: "123"},
{Success: false, Id: "125", Error: "Bad JSON.", Document: "[bad doc"},
}

ctrl := gomock.NewController(t)
Expand Down