Skip to content

Tiptap RTE: Reduce loading layout shift #19860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOvergaard merged 5 commits into from
Aug 8, 2025
Merged

Tiptap RTE: Reduce loading layout shift #19860

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7458fd1
Tiptap RTE: Set row/group min-height to prevent layout shift
leekelleher Aug 5, 2025
8793164
Added `box-sizing: border-box`
leekelleher Aug 5, 2025
2cf74c5
Adds loaded state to the editor
leekelleher Aug 5, 2025
bf945d3
Refactored toolbar to reduce the number of re-renders
leekelleher Aug 7, 2025
226c8bc
Refactored statusbar to reduce the number of re-renders
leekelleher Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...Umbraco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/input-tiptap.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
return html`
${when(loading, () => html`<div id="loader"><uui-loader></uui-loader></div>`)}
${when(!loading, () => html`${this.#renderStyles()}${this.#renderToolbar()}`)}
<div id="editor" data-mark="input:tiptap-rte"></div>
<div id="editor" data-mark="input:tiptap-rte" ?data-loaded=${!loading}></div>
${when(!loading, () => this.#renderStatusbar())}
`;
}
Expand Down Expand Up @@ -272,7 +272,7 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
display: flex;
overflow: auto;
border-radius: var(--uui-border-radius);
border: 1px solid var(--umb-tiptap-edge-border-color, var(--uui-color-border));
border: 1px solid transparent;
padding: 1rem;
box-sizing: border-box;

Expand All @@ -283,6 +283,10 @@ export class UmbInputTiptapElement extends UmbFormControlMixin<string, typeof Um
width: 100%;
max-width: 100%;

&[data-loaded] {
border-color: var(--umb-tiptap-edge-border-color, var(--uui-color-border));
}

> .tiptap {
height: 100%;
width: 100%;
Expand Down
1 change: 1 addition & 0 deletions ...aco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/tiptap-statusbar.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export class UmbTiptapStatusbarElement extends UmbLitElement {
border-top-left-radius: 0;
border-top-right-radius: 0;
border-top: 0;
box-sizing: border-box;

min-height: var(--uui-size-layout-1);
max-height: var(--uui-size-layout-2);
Expand Down
19 changes: 12 additions & 7 deletions ...braco.Web.UI.Client/src/packages/tiptap/components/input-tiptap/tiptap-toolbar.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import type { UmbPropertyEditorConfigCollection } from '@umbraco-cms/backoffice/
import '../cascading-menu-popover/cascading-menu-popover.element.js';

/**
* Provides a sticky toolbar for the {@link UmbInputTiptapElement}
* @element umb-tiptap-toolbar
* @cssprop --umb-tiptap-edge-border-color - Defines the edge border color
* @cssprop --umb-tiptap-top - Defines the top value for the sticky toolbar
*/
* Provides a sticky toolbar for the {@link UmbInputTiptapElement}
* @element umb-tiptap-toolbar
* @cssprop --umb-tiptap-edge-border-color - Defines the edge border color
* @cssprop --umb-tiptap-top - Defines the top value for the sticky toolbar
*/
@customElement('umb-tiptap-toolbar')
export class UmbTiptapToolbarElement extends UmbLitElement {
#attached = false;
Expand Down Expand Up @@ -105,6 +105,7 @@ export class UmbTiptapToolbarElement extends UmbLitElement {
border-top-color: var(--umb-tiptap-edge-border-color, var(--uui-color-border));
border-left-color: var(--umb-tiptap-edge-border-color, var(--uui-color-border));
border-right-color: var(--umb-tiptap-edge-border-color, var(--uui-color-border));
box-sizing: border-box;

background-color: var(--uui-color-surface);
color: var(--color-text);
Expand All @@ -114,7 +115,7 @@ export class UmbTiptapToolbarElement extends UmbLitElement {
flex-direction: column;

position: sticky;
top: var(--umb-tiptap-top,-25px);
top: var(--umb-tiptap-top, -25px);
left: 0;
right: 0;
padding: var(--uui-size-3);
Expand All @@ -130,17 +131,21 @@ export class UmbTiptapToolbarElement extends UmbLitElement {
flex-direction: row;
flex-wrap: wrap;

min-height: var(--uui-size-12, 36px);

.group {
display: inline-flex;
flex-wrap: wrap;
align-items: stretch;

min-height: var(--uui-size-12, 36px);

&:not(:last-child)::after {
content: '';
background-color: var(--uui-color-border);
width: 1px;
place-self: center;
height: 22px;
height: var(--uui-size-7, 21px);
margin: 0 var(--uui-size-3);
}
}
Expand Down
Loading