Property Editors: New Date Time property editors #19915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Display UTC offset instead of short offset name in label.
...s.UnitTests/Umbraco.Infrastructure/PropertyEditors/TimeOnlyPropertyIndexValueFactoryTests.cs
Outdated
Show resolved
Hide resolved
...Umbraco.Infrastructure/PropertyEditors/DateTimeWithTimeZonePropertyIndexValueFactoryTests.cs
Show resolved
Hide resolved
.../Umbraco.Infrastructure/PropertyEditors/DateTimeUnspecifiedPropertyIndexValueFactoryTests.cs
Show resolved
Hide resolved
...s.UnitTests/Umbraco.Infrastructure/PropertyEditors/DateOnlyPropertyIndexValueFactoryTests.cs
Show resolved
Hide resolved
AndyButland
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
This is so good @lauraneto - really great piece of work.
I had no further comments - just pushed up a few additional XML header comments to complete the documentation on the new classes you've introduced.
Did some testing of all different types, and looks to work flawlessly to me:
And from delivery API output:
"dateOnly": "2025-09-23",
"timeOnly": "12:14:06",
"dateUnspecified": "2025-09-23T12:14:00",
"dateLocal": "2025-09-23T12:14:00+02:00",
"dateUtc": "2025-09-23T12:14:00+00:00",
"dateWithTimezones": "2025-09-23T12:14:00+10:00"
...mbraco.Web.UI.Client/src/packages/core/components/input-time-zone/input-time-zone.element.ts
Outdated
Show resolved
Hide resolved
...rc/packages/property-editors/time-zone-picker/property-editor-ui-time-zone-picker.element.ts
Outdated
Show resolved
Hide resolved
lauraneto
changed the title
…operty-editor # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/validation/mixins/form-control.mixin.ts
8 tasks
…operty-editor # Conflicts: # src/Umbraco.Web.UI.Client/package-lock.json
lauraneto
deleted the
v17/feature/new-datetime-with-timezone-property-editor
branch
leekelleher
added a commit
that referenced
this pull request
Oct 1, 2025
iOvergaard
added a commit
that referenced
this pull request
Oct 2, 2025
* Upgrade to Tiptap v3 * Uses `@ts-expect-error` to ignore the TS complication errors These can be removed once Tiptap has resolved the TypeScript definitions. * Off-topic: corrected `flags` property in the mock data Added in PR #19915 * Update src/Umbraco.Web.UI.Client/src/packages/tiptap/extensions/link/link.tiptap-extension.ts Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Jacob Overgaard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on the new property editors can be found in: https://docs.umbraco.com/umbraco-cms/17.latest/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor