-
Notifications
You must be signed in to change notification settings - Fork 808
Document the new Date Time property editors #7431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me @lauraneto, so approving from a content perspective.
In terms of preparing the files though, maybe it would be better if you create the 17 root folder, the SUMMARY.md
page and just the necessary folder structure to create these pages in? And then move these pages there and revert the changes for the 16 versions. Then this could - I think - be merged ready for 17, and it just wouldn't be published yet as there's no "17" version in the drop-down list on the published docs site.
It would also be better as we actually don't want the changes you've made for the 16 pages of course, only on their copies for 17.
@lauraneto @AndyButland I’ve set up the v17 folders, so please don’t hesitate to make any changes to the v16 and v17 files directly. Sorry for any inconvenience this may have caused 🤞 |
It's worth noticing that we need to mention this new Property Editor on the Built-In Property Editors article. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You for the PR, @lauraneto 🙌 The PR looks great.
I have made a few suggestions to address Vale warnings and to include missing articles (like a, an, the), among other things.
@nielslyngsoe, I noticed that the DateTime and Date Time Editors are mentioned in the Built-In Property Editors article when I preview it on GitBook. I'll double-check that once it's merged and live.
Since the Date.md
article has been deleted, we need to add a redirect to the new article. I'll take care of that.
.../backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor/date-only.md
Outdated
Show resolved
Hide resolved
.../backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor/date-only.md
Outdated
Show resolved
Hide resolved
...property-editors/built-in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
Outdated
Show resolved
Hide resolved
...property-editors/built-in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
Outdated
Show resolved
Hide resolved
...property-editors/built-in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
Outdated
Show resolved
Hide resolved
...als/backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor/README.md
Outdated
Show resolved
Hide resolved
...als/backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor/README.md
Outdated
Show resolved
Hide resolved
.../backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor/time-only.md
Outdated
Show resolved
Hide resolved
.../backoffice/property-editors/built-in-umbraco-property-editors/date-time-editor/time-only.md
Outdated
Show resolved
Hide resolved
...-cms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/date-time.md
Outdated
Show resolved
Hide resolved
…in-umbraco-property-editors/date-time-editor/date-only.md
…in-umbraco-property-editors/date-time-editor/date-only.md
…in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
…in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
…in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/README.md
…in-umbraco-property-editors/date-time-editor/README.md
…in-umbraco-property-editors/date-time-editor/time-only.md
…in-umbraco-property-editors/date-time-editor/time-only.md
…in-umbraco-property-editors/date-time.md
📋 Description
This pull request adds documentation on the new Date Time property editors which will be introduced with the merge of umbraco/Umbraco-CMS#19915, which is targeting 17.0.
✅ Contributor Checklist
I've followed the Umbraco Documentation Style Guide and can confirm that:
Product & Version (if relevant)
Umbraco CMS 17.0.0
Deadline (if relevant)
Should be published along with the Umbraco 17 beta due on October 15th.