Skip to content

Conversation

lauraneto
Copy link
Contributor

@lauraneto lauraneto commented Sep 25, 2025

📋 Description

This pull request adds documentation on the new Date Time property editors which will be introduced with the merge of umbraco/Umbraco-CMS#19915, which is targeting 17.0.

✅ Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (“we”, “I”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

Product & Version (if relevant)

Umbraco CMS 17.0.0

Deadline (if relevant)

Should be published along with the Umbraco 17 beta due on October 15th.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @lauraneto, so approving from a content perspective.

In terms of preparing the files though, maybe it would be better if you create the 17 root folder, the SUMMARY.md page and just the necessary folder structure to create these pages in? And then move these pages there and revert the changes for the 16 versions. Then this could - I think - be merged ready for 17, and it just wouldn't be published yet as there's no "17" version in the drop-down list on the published docs site.

It would also be better as we actually don't want the changes you've made for the 16 pages of course, only on their copies for 17.

@eshanrnh
Copy link
Contributor

@lauraneto @AndyButland I’ve set up the v17 folders, so please don’t hesitate to make any changes to the v16 and v17 files directly. Sorry for any inconvenience this may have caused 🤞

@lauraneto lauraneto marked this pull request as ready for review October 1, 2025 07:26
@nielslyngsoe
Copy link
Member

It's worth noticing that we need to mention this new Property Editor on the Built-In Property Editors article.
@eshanrnh can you make this happen when we merge?

Copy link
Contributor

@eshanrnh eshanrnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You for the PR, @lauraneto 🙌 The PR looks great.

I have made a few suggestions to address Vale warnings and to include missing articles (like a, an, the), among other things.

@nielslyngsoe, I noticed that the DateTime and Date Time Editors are mentioned in the Built-In Property Editors article when I preview it on GitBook. I'll double-check that once it's merged and live.

Since the Date.md article has been deleted, we need to add a redirect to the new article. I'll take care of that.

…in-umbraco-property-editors/date-time-editor/date-only.md
…in-umbraco-property-editors/date-time-editor/date-only.md
…in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
…in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
…in-umbraco-property-editors/date-time-editor/date-time-unspecified.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/date-time-with-time-zone.md
…in-umbraco-property-editors/date-time-editor/README.md
…in-umbraco-property-editors/date-time-editor/README.md
…in-umbraco-property-editors/date-time-editor/time-only.md
…in-umbraco-property-editors/date-time-editor/time-only.md
@eshanrnh eshanrnh merged commit a9173cc into main Oct 8, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants