-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Tiptap RTE: Localizes property editor UI label (removes "[Tiptap]" from label) (closes #20439) #20713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements localization support for the Tiptap Rich Text Editor's display label. The label is being changed from a hardcoded string to a localization key to support internationalization.
- Changed the Tiptap property editor label from hardcoded "Rich Text Editor [Tiptap]" to a localization key "#rte_label"
- Updated UI components to properly localize property editor labels using
localize.string() - Updated acceptance test to match the simplified display name
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/tiptap-rte/manifests.ts |
Changed label from hardcoded string to localization key #rte_label |
src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts |
Added localization support for property editor labels in the data type picker flow |
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-picker-modal.element.ts |
Added localization support for property editor labels in the UI picker modal |
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts |
Updated test to use simplified display name "Rich Text Editor" instead of "Rich Text Editor [Tiptap]" |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts:353
- The
labelattribute on lines 353 and 361 is not usinglocalize.string()for localization. While the rendered content in#renderItemContent()correctly usesthis.localize.string(), thelabelattribute (used for accessibility and tooltips) still references the raw value. These should also be localized:label=${this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name)}
label=${propertyEditorUI.meta.label || propertyEditorUI.name}
src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts:361
- The
labelattribute on lines 353 and 361 is not usinglocalize.string()for localization. While the rendered content in#renderItemContent()correctly usesthis.localize.string(), thelabelattribute (used for accessibility and tooltips) still references the raw value. These should also be localized:label=${this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name)}
label=${propertyEditorUI.meta.label || propertyEditorUI.name}
src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/tiptap-rte/manifests.ts
Show resolved
Hide resolved
…in the other places
nielslyngsoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes looks good! Off to test the branch.
iOvergaard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch with the addition of localization!
Description
Fixes #20439.
Localizes the label for the RTE property-editor UI. This removes the reference to "[Tiptap]" from the button's label (in the data-type and property-editor picker modals).
Also updated the corresponding acceptance test.