Skip to content

Conversation

@leekelleher
Copy link
Member

Description

Fixes #20439.

Localizes the label for the RTE property-editor UI. This removes the reference to "[Tiptap]" from the button's label (in the data-type and property-editor picker modals).

Also updated the corresponding acceptance test.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements localization support for the Tiptap Rich Text Editor's display label. The label is being changed from a hardcoded string to a localization key to support internationalization.

  • Changed the Tiptap property editor label from hardcoded "Rich Text Editor [Tiptap]" to a localization key "#rte_label"
  • Updated UI components to properly localize property editor labels using localize.string()
  • Updated acceptance test to match the simplified display name

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/tiptap-rte/manifests.ts Changed label from hardcoded string to localization key #rte_label
src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts Added localization support for property editor labels in the data type picker flow
src/Umbraco.Web.UI.Client/src/packages/core/property-editor/ui-picker-modal/property-editor-ui-picker-modal.element.ts Added localization support for property editor labels in the UI picker modal
tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts Updated test to use simplified display name "Rich Text Editor" instead of "Rich Text Editor [Tiptap]"
Comments suppressed due to low confidence (2)

src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts:353

  • The label attribute on lines 353 and 361 is not using localize.string() for localization. While the rendered content in #renderItemContent() correctly uses this.localize.string(), the label attribute (used for accessibility and tooltips) still references the raw value. These should also be localized: label=${this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name)}
					label=${propertyEditorUI.meta.label || propertyEditorUI.name}

src/Umbraco.Web.UI.Client/src/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts:361

  • The label attribute on lines 353 and 361 is not using localize.string() for localization. While the rendered content in #renderItemContent() correctly uses this.localize.string(), the label attribute (used for accessibility and tooltips) still references the raw value. These should also be localized: label=${this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name)}
					label=${propertyEditorUI.meta.label || propertyEditorUI.name}

@leekelleher leekelleher changed the title Tiptap RTE: Localizes property editor UI label (removes "[Tiptap]" from label) Tiptap RTE: Localizes property editor UI label (removes "[Tiptap]" from label) (closes #20439) Nov 3, 2025
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good! Off to test the branch.

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 3, 2025 11:32
@nielslyngsoe nielslyngsoe requested review from nielslyngsoe and removed request for iOvergaard November 3, 2025 11:34
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch with the addition of localization!

@nielslyngsoe nielslyngsoe merged commit c1a8500 into main Nov 3, 2025
28 checks passed
@nielslyngsoe nielslyngsoe deleted the v17/feature/rte-property-editor-ui-label branch November 3, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V17: The RTE data type should not contain "[TipTap]" in its name.

4 participants