Skip to content

Tiptap RTE: Localizes property editor UI label (removes "[Tiptap]" from label) (closes #20439) #20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 4 commits into from
Nov 3, 2025
Merged

Tiptap RTE: Localizes property editor UI label (removes "[Tiptap]" from label) (closes #20439) #20713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bef771
Localized RTE property-editor UI label, removing "[Tiptap]"
leekelleher Nov 3, 2025
205296f
Updated acceptance test
leekelleher Nov 3, 2025
939b906
Localized the button label in the data-type and property-editor picke…
leekelleher Nov 3, 2025
3323c99
Based on @copilot suggestion, localized the property-editor UI label …
leekelleher Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../packages/core/property-editor/ui-picker-modal/property-editor-ui-picker-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ export class UmbPropertyEditorUIPickerModalElement extends UmbModalBaseElement<
<li class="item" ?selected=${this.value.selection.includes(propertyEditorUI.alias)}>
<button type="button" @click=${() => this.#handleClick(propertyEditorUI)}>
<umb-icon name=${propertyEditorUI.meta.icon} class="icon"></umb-icon>
${propertyEditorUI.meta.label || propertyEditorUI.name}
${this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name)}
</button>
</li>
`,
Expand Down
17 changes: 7 additions & 10 deletions ...rc/packages/data-type/modals/data-type-picker-flow/data-type-picker-flow-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,30 +347,27 @@ export class UmbDataTypePickerFlowModalElement extends UmbModalBaseElement<
}

#renderDataTypeButton(propertyEditorUI: ManifestPropertyEditorUi, createAsNewOnPick?: boolean) {
const label = this.localize.string(propertyEditorUI.meta.label || propertyEditorUI.name);
if (createAsNewOnPick) {
return html`
<uui-button
label=${propertyEditorUI.meta.label || propertyEditorUI.name}
@click=${() => this.#createDataType(propertyEditorUI.alias)}>
${this.#renderItemContent(propertyEditorUI)}
<uui-button label=${label} @click=${() => this.#createDataType(propertyEditorUI.alias)}>
${this.#renderItemContent(label, propertyEditorUI)}
</uui-button>
`;
} else {
return html`
<uui-button
label=${propertyEditorUI.meta.label || propertyEditorUI.name}
href=${this._dataTypePickerModalRouteBuilder!({ uiAlias: propertyEditorUI.alias })}>
${this.#renderItemContent(propertyEditorUI)}
<uui-button label=${label} href=${this._dataTypePickerModalRouteBuilder!({ uiAlias: propertyEditorUI.alias })}>
${this.#renderItemContent(label, propertyEditorUI)}
</uui-button>
`;
}
}

#renderItemContent(propertyEditorUI: ManifestPropertyEditorUi) {
#renderItemContent(label: string, propertyEditorUI: ManifestPropertyEditorUi) {
return html`
<div class="item-content">
<umb-icon name=${propertyEditorUI.meta.icon} class="icon"></umb-icon>
${propertyEditorUI.meta.label || propertyEditorUI.name}
${label}
</div>
`;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/tiptap-rte/manifests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const manifests: Array<ManifestPropertyEditorUi> = [
name: 'Rich Text Editor [Tiptap] Property Editor UI',
element: () => import('./property-editor-ui-tiptap.element.js'),
meta: {
label: 'Rich Text Editor [Tiptap]',
label: '#rte_label',
propertyEditorSchemaAlias: 'Umbraco.RichText',
icon: 'icon-browser-window',
group: 'richContent',
Expand Down
2 changes: 1 addition & 1 deletion tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/Tiptap.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test.afterEach(async ({umbracoApi}) => {

test('can create a rich text editor with tiptap', {tag: '@smoke'}, async ({umbracoApi, umbracoUi}) => {
// Arrange
const tipTapLocatorName = 'Rich Text Editor [Tiptap]';
const tipTapLocatorName = 'Rich Text Editor';
const tipTapAlias = 'Umbraco.RichText';
const tipTapUiAlias = 'Umb.PropertyEditorUi.Tiptap';

Expand Down
Loading