-
Notifications
You must be signed in to change notification settings - Fork 811
Fixed vale errors and added missing descriptions #6669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some suggestions and comments.
For the warnings on the lists, where it complains about how each item should start with a capital letter - please update that to use inline code, as that also make sense, for the parameter names 💪
13/umbraco-engage/developers/personalization/implement-your-own-segment-parameters.md
Outdated
Show resolved
Hide resolved
13/umbraco-engage/getting-started/for-developers/infrastructure-sizing.md
Outdated
Show resolved
Hide resolved
13/umbraco-engage/getting-started/for-marketers-and-editors/cockpit.md
Outdated
Show resolved
Hide resolved
...keters-and-editors/personalization/implicit-and-explicit-personalization/campaign-scoring.md
Outdated
Show resolved
Hide resolved
...keters-and-editors/personalization/implicit-and-explicit-personalization/campaign-scoring.md
Outdated
Show resolved
Hide resolved
…n-segment-parameters.md Co-authored-by: sofietoft <[email protected]>
…ckpit.md Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
…testing.md Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
…testing.md Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
…ents.md Co-authored-by: sofietoft <[email protected]>
…it-and-explicit-personalization/campaign-scoring.md Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
Co-authored-by: sofietoft <[email protected]>
…gage-page-descriptions
|
Thanks @sofietoft for your review. I've incorporated your suggestions/comments 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 💪
Just a final suggestion, related to the ROAR acronym it's still complaining about 😅
|
The error is gone now 🤩 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 😄
Description
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Engage v13
Deadline (if relevant)
Anytime