Skip to content

Conversation

@eshanrnh
Copy link
Contributor

@eshanrnh eshanrnh commented Nov 14, 2024

Description

What did you add/update/change?

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Engage v13

Deadline (if relevant)

Anytime

@eshanrnh eshanrnh marked this pull request as ready for review November 15, 2024 10:19
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some suggestions and comments.

For the warnings on the lists, where it complains about how each item should start with a capital letter - please update that to use inline code, as that also make sense, for the parameter names 💪

eshanrnh and others added 13 commits November 18, 2024 12:11
…it-and-explicit-personalization/campaign-scoring.md

Co-authored-by: sofietoft <[email protected]>
@eshanrnh
Copy link
Contributor Author

Thanks @sofietoft for your review. I've incorporated your suggestions/comments 💪

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💪

Just a final suggestion, related to the ROAR acronym it's still complaining about 😅

@eshanrnh
Copy link
Contributor Author

The error is gone now 🤩

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 😄

@eshanrnh eshanrnh merged commit 5263b45 into main Nov 18, 2024
2 of 3 checks passed
@eshanrnh eshanrnh deleted the engage-page-descriptions branch November 21, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants