feat: fix precommit container error #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuluo-yx
commented
Sep 20, 2025
yuluo-yx
commented
- Closed Run pre-commit in Containers #140
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
yuluo-yx
changed the title
Signed-off-by: yuluo-yx <[email protected]>
yuluo-yx
force-pushed
the
0920-yuluo/fix-precommit-container
branch
from
4481ba9 to
0f858ea
Compare
|
run test success: exec container and manual run pre-commit : 
by make precommit-local 
|
rootfs
reviewed
Sep 20, 2025
| precommit-local: | ||
| docker pull ghcr.io/vllm/semantic-router/precommit:latest | ||
| docker run --rm -v $$(pwd):/data ghcr.io/vllm-project/semantic-router/precommit:latest pre-commit run --all-files | ||
| @if ! docker image inspect ${PRECOMMIT_CONTAINER} > /dev/null 2>&1; then \ |
There was a problem hiding this comment.
nit: can you make a macro for docker command and detect if either docker or podman is installed and choose the one that is present on the system?
There was a problem hiding this comment.
you can do it in a followup PR.
rootfs
approved these changes
Sep 20, 2025
yossiovadia
pushed a commit
to yossiovadia/semantic-router
that referenced
this pull request
Oct 8, 2025
Signed-off-by: yuluo-yx <[email protected]> Co-authored-by: Huamin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.