Skip to content

feat: fix precommit container error #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

feat: fix precommit container error #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f858ea
feat: fix precommit container erro
yuluo-yx Sep 20, 2025
e8dd221
Merge branch 'main' into 0920-yuluo/fix-precommit-container
rootfs Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile.precommit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,17 @@ RUN apt-get update && apt-get install -y \
build-essential \
pkg-config \
python3 \
libssl-dev \
ca-certificates \
python3-pip

# Install Node.js and npm
RUN curl -fsSL https://deb.nodesource.com/setup_lts.x | bash - && \
apt-get install -y nodejs

# Install Rust
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y && \
. $HOME/.cargo/env
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
ENV PATH="/root/.cargo/bin:${PATH}"

# Markdown
RUN npm install -g markdownlint-cli
Expand Down
24 changes: 22 additions & 2 deletions tools/make/pre-commit.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
PRECOMMIT_CONTAINER := ghcr.io/vllm-project/semantic-router/precommit:latest

precommit-install:
pip install pre-commit

Expand All @@ -19,6 +21,24 @@ precommit-check:
echo "No Go, Rust, JavaScript, Markdown, Yaml, or Python files found to check"; \
fi

# Run pre-commit hooks in a Docker container,
# and you can exec container to run bash for debug.
# export PRECOMMIT_CONTAINER=ghcr.io/vllm-project/semantic-router/precommit:latest
# docker run --rm -it \
# -v $(pwd):/app \
# -w /app \
# --name precommit-container ${PRECOMMIT_CONTAINER} \
# bash
# and then, run `pre-commit install && pre-commit run --all-files` command
precommit-local:
docker pull ghcr.io/vllm/semantic-router/precommit:latest
docker run --rm -v $$(pwd):/data ghcr.io/vllm-project/semantic-router/precommit:latest pre-commit run --all-files
@if ! docker image inspect ${PRECOMMIT_CONTAINER} > /dev/null 2>&1; then \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you make a macro for docker command and detect if either docker or podman is installed and choose the one that is present on the system?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do it in a followup PR.

echo "Image not found locally. Pulling..."; \
docker pull ${PRECOMMIT_CONTAINER}; \
else \
echo "Image found locally. Skipping pull."; \
fi
docker run --rm \
-v $(shell pwd):/app \
-w /app \
--name precommit-container ${PRECOMMIT_CONTAINER} \
bash -c "source ~/.cargo/env && pre-commit install && pre-commit run --all-files"
Loading