[BugFix][Core] Fix error when enable async-scheduling in multi-node env #25887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a launch failure for async scheduling in a multi-node environment by adjusting when the distributed executor backend is configured. The change correctly removes the premature default setting of the backend to mp. However, the new validation logic for supported backends with async scheduling seems to have some inconsistencies. I've added a comment with a suggestion to clarify this logic and make it consistent with the information provided in the pull request description.
Contributor
Author
|
@WoosukKwon @benchislett Hello, could you please review this MR? |
lhtin
force-pushed
the
fix-async-scheduling-with-ray
branch
from
2a3e01f to
5f213a1
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
lhtin
force-pushed
the
fix-async-scheduling-with-ray
branch
from
5f213a1 to
5aa3adc
Compare
Contributor
Author
|
@WoosukKwon @benchislett Hi, could you take a look at this PR? |
lhtin
changed the title
lhtin
changed the title
benchislett
reviewed
Oct 16, 2025
benchislett
reviewed
Oct 16, 2025
benchislett
approved these changes
Oct 16, 2025
Collaborator
benchislett
left a comment
benchislett
left a comment
There was a problem hiding this comment.
LGTM, one grammar nit
lhtin
force-pushed
the
fix-async-scheduling-with-ray
branch
from
f4bb3bd to
54e56a5
Compare
…he default selection. Signed-off-by: Lehua Ding <[email protected]>
Co-authored-by: Benjamin Chislett <[email protected]> Signed-off-by: Lehua Ding <[email protected]>
Signed-off-by: Lehua Ding <[email protected]>
lhtin
force-pushed
the
fix-async-scheduling-with-ray
branch
from
54e56a5 to
bc67b60
Compare
benchislett
approved these changes
Oct 17, 2025
benchislett
added
bug
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
adabeyta
pushed a commit
to adabeyta/vllm
that referenced
this pull request
Oct 20, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 23, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]> Signed-off-by: Alberto Perdomo <[email protected]>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]> Signed-off-by: 0xrushi <[email protected]>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]> Signed-off-by: 0xrushi <[email protected]>
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Nov 12, 2025
…nv (vllm-project#25887) Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching in a multi-node environment (e.g., TP16), the ParallelConfig automatically selects
rayas the distributed_executor_backend. However, when async scheduling is enabled, it prematurely sets the default value of distributed_executor_backendto to mp, causing a launch failure like bellow. This fix moves the check to after that the backend is auto-selected.Currently, async scheduling (primarily the fully overlap feature) does not support Ray as a backend(error like bellow). Support for this can be added in a future PR.