Skip to content

Conversation

limbonaut
Copy link
Collaborator

@limbonaut limbonaut commented Sep 19, 2025

DESCRIBE YOUR PR

In Godot SDK, add a note to attach_screenshot option that it is experimental and not recommended for production use at this point. According to changes in this PR:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 19, 2025 3:46pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 19, 2025 3:46pm

@limbonaut limbonaut marked this pull request as ready for review September 19, 2025 09:44
Copy link

codecov bot commented Sep 19, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.12MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.85MB -9 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/iUDu2_9tWPjtZijhSbAo9/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/iUDu2_9tWPjtZijhSbAo9/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/sloG4HoJKklzsHVtP039N/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/sloG4HoJKklzsHVtP039N/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️


<Alert level="warning" title="Important">

This feature is experimental and may impact performance when screenshots are captured. Not recommended for production use.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the last "not recommended for production" because I feel it's beating a dead horse

We have this under a waning box. Saying it's experimental. I feel that's enough warning already

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced it with softer version. Hopefully, it doesn't make an impression of beating a dead horse now.

@codeowner-assignment codeowner-assignment bot requested a review from a team September 19, 2025 14:46
Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding these warnings.

@limbonaut limbonaut merged commit 6f66256 into master Sep 22, 2025
13 checks passed
@limbonaut limbonaut deleted the chore/mark-screenshot-experimental branch September 22, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants