chore(deps): bump getsentry/github-workflows from 2 to 3 and fix breaking changes #5218
+80
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21c9e75+dirty | 356.73 ms | 381.06 ms | 24.33 ms |
| a0b15d6+dirty | 414.33 ms | 448.85 ms | 34.52 ms |
| 77061ed+dirty | 359.40 ms | 424.10 ms | 64.70 ms |
| 818a608+dirty | 350.29 ms | 397.38 ms | 47.09 ms |
| b3b5b0d+dirty | 361.42 ms | 403.90 ms | 42.48 ms |
| 1853710+dirty | 360.67 ms | 396.28 ms | 35.61 ms |
| a2bb688+dirty | 371.19 ms | 389.18 ms | 17.99 ms |
| 20daa0a+dirty | 352.33 ms | 424.30 ms | 71.98 ms |
| a02e30b+dirty | 346.13 ms | 381.76 ms | 35.62 ms |
| e2fa43d+dirty | 326.56 ms | 372.88 ms | 46.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 21c9e75+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a0b15d6+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 77061ed+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 818a608+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| b3b5b0d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 1853710+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| a2bb688+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 20daa0a+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a02e30b+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| e2fa43d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1bea095+dirty | 1234.14 ms | 1233.96 ms | -0.18 ms |
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
| ba75c7c+dirty | 1235.86 ms | 1226.45 ms | -9.41 ms |
| 6479fd5+dirty | 1228.48 ms | 1231.32 ms | 2.84 ms |
| 7480abe+dirty | 1220.53 ms | 1244.18 ms | 23.65 ms |
| c4e097a+dirty | 1229.09 ms | 1242.61 ms | 13.53 ms |
| 69602ce+dirty | 1235.65 ms | 1230.82 ms | -4.83 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| d751a5d+dirty | 1215.57 ms | 1220.56 ms | 4.99 ms |
| 955f2eb+dirty | 1235.06 ms | 1253.88 ms | 18.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1bea095+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ba75c7c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 6479fd5+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 7480abe+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| c4e097a+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| 69602ce+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d751a5d+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 955f2eb+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1bea095+dirty | 1218.93 ms | 1212.37 ms | -6.57 ms |
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
| ba75c7c+dirty | 1236.14 ms | 1240.69 ms | 4.55 ms |
| 6479fd5+dirty | 1207.80 ms | 1215.12 ms | 7.32 ms |
| 7480abe+dirty | 1219.84 ms | 1223.60 ms | 3.76 ms |
| c4e097a+dirty | 1231.35 ms | 1246.91 ms | 15.56 ms |
| 69602ce+dirty | 1230.59 ms | 1230.84 ms | 0.24 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| d751a5d+dirty | 1212.22 ms | 1217.94 ms | 5.71 ms |
| 955f2eb+dirty | 1225.78 ms | 1239.27 ms | 13.49 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1bea095+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ba75c7c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 6479fd5+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 7480abe+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| c4e097a+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| 69602ce+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d751a5d+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 955f2eb+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
# Conflicts: # .github/workflows/danger.yml # .github/workflows/update-deps.yml
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 77061ed+dirty | 369.55 ms | 408.35 ms | 38.80 ms |
| a2bb688+dirty | 409.65 ms | 410.45 ms | 0.80 ms |
| 000da7a | 454.46 ms | 445.00 ms | -9.46 ms |
| a0b15d6 | 423.06 ms | 437.77 ms | 14.71 ms |
| af9331b | 449.77 ms | 479.20 ms | 29.43 ms |
| 69602ce | 417.47 ms | 443.52 ms | 26.05 ms |
| 7480abe+dirty | 411.60 ms | 405.81 ms | -5.78 ms |
| 8a4ce6f | 422.88 ms | 408.33 ms | -14.55 ms |
| bc9680d | 375.15 ms | 401.12 ms | 25.97 ms |
| 46da307 | 455.92 ms | 443.79 ms | -12.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 77061ed+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| a2bb688+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 000da7a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| a0b15d6 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| af9331b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 69602ce | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 7480abe+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 8a4ce6f | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| bc9680d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 46da307 | 17.75 MiB | 19.68 MiB | 1.93 MiB |
antonis
changed the title
antonis
changed the title
|
Currently blocked in getsentry/github-workflows#128 |
vaind
added a commit
that referenced
this pull request
Oct 9, 2025
Tests whether updater has permission issues when running in a pr branch. Related to #5218 and getsentry/github-workflows#128
|
Unblock when:
|
|
@antonis i've bumped updater to v3 (currently pointing to 3.1.0) and everything but the javascript update worked fine. That one may have been an issue with the update being merged recently and not on this branch so I've merged main in. |
|
Thank you @vaind 🙇 All the updater jobs are 🟢 now 🎉 |
This reverts commit 26e20ad.
vaind
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR fixes the breaking change in https://github.com/getsentry/github-workflows/releases/tag/3.0.0 and bumps workflows to v3
💡 Motivation and Context
Breaking changes
💚 How did you test it?
CI (job run)
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog