Skip to content

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 18, 2025

Ignore files that have syntax errors because the parser can't parse them, so formatting them is pointless.

Copy link
Member Author

Dunqing commented Sep 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 09-17-feat_tasks_coverage_ignore_tests_that_have_syntax_error branch from adda5f5 to 22a1c7f Compare September 18, 2025 14:11
@graphite-app graphite-app bot changed the base branch from 09-17-feat_formatter_keep_parse_options_consistent_for_all_formatter_usages to graphite-base/13885 September 18, 2025 23:18
@graphite-app graphite-app bot force-pushed the 09-17-feat_tasks_coverage_ignore_tests_that_have_syntax_error branch from 22a1c7f to 4b93c55 Compare September 18, 2025 23:25
@graphite-app graphite-app bot force-pushed the graphite-base/13885 branch from 8b7f7c3 to 2cead8b Compare September 18, 2025 23:25
@graphite-app graphite-app bot changed the base branch from graphite-base/13885 to main September 18, 2025 23:26
@graphite-app graphite-app bot force-pushed the 09-17-feat_tasks_coverage_ignore_tests_that_have_syntax_error branch from 4b93c55 to 5fb3ecc Compare September 18, 2025 23:26
@Boshen Boshen changed the title feat(tasks/coverage): ignore tests that have syntax error feat(tasks/coverage): ignore formatter tests that have syntax error Sep 19, 2025
@Dunqing Dunqing marked this pull request as draft September 21, 2025 13:46
@Dunqing
Copy link
Member Author

Dunqing commented Sep 21, 2025

Converted to draft. If this PR had been merged first, it would have caused all PRs of stack to fix conflicts. Therefore, it has been converted to draft to avoid this huge waste of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant