Skip to content

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 19, 2025

// normal function
function a() {}

// declare function
declare function a(): void;

declare function without a function body, so it behaves like a declare var a: void, thus the semicolon is needed

Copy link
Member Author

Dunqing commented Sep 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Sep 19, 2025

CodSpeed Instrumentation Performance Report

Merging #13928 will not alter performance

Comparing 09-19-fix_formatter_missing_semicolon_for_declare_function (3ce0775) with 09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation (06a1df6)

Summary

✅ 37 untouched

@Dunqing Dunqing requested a review from leaysgur September 22, 2025 03:23
@graphite-app graphite-app bot force-pushed the 09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation branch from 70c33a9 to 5c14ec9 Compare September 22, 2025 04:15
@graphite-app graphite-app bot force-pushed the 09-19-fix_formatter_missing_semicolon_for_declare_function branch from c5ef8de to 13e074a Compare September 22, 2025 04:15
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Sep 22, 2025
Copy link
Member

leaysgur commented Sep 22, 2025

Merge activity

```ts
// normal function
function a() {}

// declare function
declare function a(): void;
```

`declare function` without a function body, so it behaves like a `declare var a: void`, thus the semicolon is needed
@graphite-app graphite-app bot force-pushed the 09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation branch from 5c14ec9 to 06a1df6 Compare September 22, 2025 04:26
@graphite-app graphite-app bot force-pushed the 09-19-fix_formatter_missing_semicolon_for_declare_function branch from 13e074a to 3ce0775 Compare September 22, 2025 04:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 22, 2025
Base automatically changed from 09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation to main September 22, 2025 04:32
@graphite-app graphite-app bot merged commit 3ce0775 into main Sep 22, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 09-19-fix_formatter_missing_semicolon_for_declare_function branch September 22, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-formatter Area - Formatter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants