-
-
Notifications
You must be signed in to change notification settings - Fork 664
fix(formatter): missing semicolon for declare
function
#13928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
09-19-fix_formatter_missing_semicolon_for_declare_function
Sep 22, 2025
Merged
fix(formatter): missing semicolon for declare
function
#13928
graphite-app
merged 1 commit into
main
from
09-19-fix_formatter_missing_semicolon_for_declare_function
Sep 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2025
CodSpeed Instrumentation Performance ReportMerging #13928 will not alter performanceComparing Summary
|
This was referenced Sep 21, 2025
70c33a9
to
5c14ec9
Compare
c5ef8de
to
13e074a
Compare
Merge activity
|
```ts // normal function function a() {} // declare function declare function a(): void; ``` `declare function` without a function body, so it behaves like a `declare var a: void`, thus the semicolon is needed
5c14ec9
to
06a1df6
Compare
13e074a
to
3ce0775
Compare
Base automatically changed from
09-19-feat_formatter_implement_formatting_for_tstypeparameter_and_tstypeparameterinstantiation
to
main
September 22, 2025 04:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
declare function
without a function body, so it behaves like adeclare var a: void
, thus the semicolon is needed