-
Notifications
You must be signed in to change notification settings - Fork 27
fix: support persisted views for cloud catalog #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6e085c2 to
39843c3
Compare
6b9a23e to
f451b4f
Compare
39843c3 to
62aa9f2
Compare
bcallender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, just a couple minor nits
62aa9f2 to
cdd5060
Compare
4260ef1 to
222310d
Compare

TL;DR
Implemented view support for the CloudCatalog, enabling creation, listing, description, and deletion of views in the cloud backend.
What changed?
Added view management functionality to the CloudCatalog class
Refactored common functionality since views and tables are datasets:
_drop_dataset()to handle both table and view deletion_get_tables_for_database()to_get_datasets_for_database()to handle both tables and viewsAdded utility functions for converting between bytes and strings to be used in Serde:
get_string_from_bytes()andget_bytes_from_string()Have separate error codes for Views: