Skip to content

Conversation

@german-typedef
Copy link
Contributor

@german-typedef german-typedef commented Aug 15, 2025

TL;DR

Implemented view support for the CloudCatalog, enabling creation, listing, description, and deletion of views in the cloud backend.

What changed?

  • Added view management functionality to the CloudCatalog class

  • Refactored common functionality since views and tables are datasets:

    • Created _drop_dataset() to handle both table and view deletion
    • Renamed _get_tables_for_database() to _get_datasets_for_database() to handle both tables and views
  • Added utility functions for converting between bytes and strings to be used in Serde:

    • get_string_from_bytes() and get_bytes_from_string()
    • Standardized base64 encoding/decoding across the codebase
  • Have separate error codes for Views:

    • ViewAlreadyExistsError
    • ViewNotFoundError

Copy link
Contributor Author

german-typedef commented Aug 15, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@german-typedef german-typedef requested a review from a team August 15, 2025 22:54
@german-typedef german-typedef marked this pull request as ready for review August 15, 2025 22:54
@german-typedef german-typedef force-pushed the 08-15-fix_support_persisted_views_for_cloud_catalog branch from 6e085c2 to 39843c3 Compare August 15, 2025 23:55
@german-typedef german-typedef force-pushed the 07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session branch from 6b9a23e to f451b4f Compare August 19, 2025 16:59
@german-typedef german-typedef force-pushed the 08-15-fix_support_persisted_views_for_cloud_catalog branch from 39843c3 to 62aa9f2 Compare August 19, 2025 16:59
Copy link
Contributor

@bcallender bcallender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, just a couple minor nits

@german-typedef german-typedef force-pushed the 08-15-fix_support_persisted_views_for_cloud_catalog branch from 62aa9f2 to cdd5060 Compare August 19, 2025 18:20
@german-typedef german-typedef force-pushed the 07-17-fix_use_the_cloud_catalog_when_doing_save_as_table_in_a_cloud_session branch from 4260ef1 to 222310d Compare August 19, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants