Fix zzip build in mac&windows releases, add to make default target #83059
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Code: Build
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This was referenced Sep 27, 2025
github-actions
bot
added
json-styled
|
https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/18061793159/job/51399067637?pr=83059#step:16:577 it actually built it this time. |
github-actions
bot
added
the
BasicBuildPassed
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix the release builds which actually build the zzip binary, unlike CI. Make CI also build the zzip binary to catch these breaks in the future.
Describe the solution
Fix the c++ for loop definition to not un-const the map entry key. Add $(ZZIP_BIN) to the make default target which is what build-scripts/gha_compile_only.sh is building.
Describe alternatives you've considered
Make the zzip binary optional for a release.
Testing
CI?
Additional context